[BUG][FIX] String containing single space breaks on #trimBlanks ( v.3 even better )

David T. Lewis lewis at mail.msen.com
Mon Feb 9 10:39:27 UTC 2004


According to Smalltalk/X, #trimBlanks is a "Smalltalk/V compatibility"
method, so maybe it is there for a reason.

Dave

On Mon, Feb 09, 2004 at 09:00:54AM +0100, ducasse wrote:
> 
> On 9 févr. 04, at 07:28, Julian Fitzell wrote:
> 
> > Hmm... how about we pick one and mark the other as deprecated - then  
> > we can move towards *not* having two equivalent methods...
> >
> > I'd suggest one, but I don't think I really have any strong feeling in  
> > either direction.  #withBlanksTrimmed seems more appropriate for  
> > something that returns a new object rather than modifying the  
> > receiver, but then String isn't consistent in this regard anyway and  
> > #trimBlanks is shorter... :)
> 
> Yeap pick one and deprecate the other.
> 
> I imagine that it should also pass the tests I wrote.
> 
> Stef
> >
> > Julian
> >
> > Brent Vukmer wrote:
> >> from preamble:
> >> "Change Set:		String-trimBlanks-bkv
> >> Date:			7 February 2004
> >> Author:			Brent Vukmer <brentvukmer at yahoo.com>
> >> v3 - now trimBlanks just calls withBlanksTrimmed.  :)  Not sure why
> >> String defines two equivalent methods.  But withBlanksTrimmed as
> >> currently defined appears to pass all of the tests that Lukas
> >> supplied."!



More information about the Squeak-dev mailing list