[FIX] Re: Can't abandon sources
Dan at SqueakLand.org
Mon Jan 5 06:36:39 UTC 2004
"Andreas Raab" <andreas.raab at gmx.de> wrote...
>So why not signal a warning and let the user decide if to proceed? Seems to
>me that many people won't be overly concerned with loosing a few temp names
>in methods that cannot be compressed accordingly. Attached is a fix that
>warns about the problem and gives three choices to proceed:
>- Abort operation and keep original sources
>- Proceed and replace temps with t1 ... tN
>- Proceed and do not warn again
This is certainly the simplest thing to do right now. I would point out that abandonSources is almost always used as a step toward dropping the sources file, and therefore "keep original sources" might well cause more confusion than just forcing tN's in the problem cases. A disclaimer about the limitation could easily be folded into the already considerable warning at the beginning of the method.
One could, of course, rename the fewest number of temps that will allow the old scheme to work. Then even the problem methods would retain mostly readable temps, and yet no change to the trailer byte convention would be required (this seemed to worry the folks who last looked at it). Methinks this would take more code than "doing it right", but it's definitely an option.
More information about the Squeak-dev