Problem with update 5947 changes to SimpleServiceEntry and BFAV2

Ken Causey ken at
Tue Jun 8 22:23:21 UTC 2004

Well, today's harvesting party is a bust due to an incompatibility
between BFAV2 and update 5947.

In update 5947 Ned provided some FileList* related changes including
changing the usage of SimpleServiceEntry.  Pre-5947 SimpleServiceEntry
assumed that you passed it the list of arguments for the service when
calling SimpleServiceEntry>>performServiceFor: or
SimpleServiceEntry>>performExtraFor: and friends.  Admittedly this
resulted in some rather strange looking code like 

performAttachmentService: aServiceEntry on: anAttachment
	aServiceEntry perform: aServiceEntry requestSelector
		withArguments: { aServiceEntry getArgumentsFrom: 
							(PatchArchiveAttachment fullName: anAttachment) }.

With 5947 Ned changed performServiceFor: so that it assumes that is is
supposed to extract the arguments with getArgumentsFrom:.  The more I
think about it the more this seems like the correct thing to do. 
However I will note that performExtraFor: has not been updated to follow
this convention.

I guess my suggestion for now is that BFAV2 be updated to take this new
model into consideration.  Here's a small changeset against 5.09...

uh, hmm...

Looks like it's not going to be that easy.  5947 changes things all over
the place.  The services don't seem to standardize on wanting the just
the filename anymore...  Namely, FileContentsBrowser
class>>serviceBrowserCompressedCode expects something closer to a
FileList than what the facade PatchArchiveAttachment provides.  It's
just a bit funny that this facade was provides for BFAV by Ned. ;)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the Squeak-dev mailing list