[ENH] SMTPClientSenderBracket-nk ([er][et][sm][sl] Looks good; test attached)

Frank Shearar frank.shearar at rnid.org.uk
Tue Mar 23 17:18:48 UTC 2004


> >>> "Ned Konz" 03/23/04 16:55 >>>
> 
> On Tuesday 23 March 2004 2:45 am, Frank Shearar wrote:
> > One thing that the implementation above does that differs 
> from Ned's is
> > that if
> > you pass in 'Frank <frank at angband.za.org>' you'll lose the 
> 'Frank ' part. I
> > don't know if that's such a nice thing. As MailAddressParser's class
> > comment says, "It would be nice to also get a list ('Joe <joe at foo>'
> > *'<jane>')." So maybe
> > we should use my code snippet above, and make 
> MailAddressParser Do The
> > Right Thing?
> 
> Go for it!

Upon further inspection (in RFC 2821), MAIL FROM takes a reverse-path.
A reverse-path is a Path, defined as:

      Path = "<" [ A-d-l ":" ] Mailbox ">"
      A-d-l = At-domain *( "," A-d-l )
            ; Note that this form, the so-called "source route",
            ; MUST BE accepted, SHOULD NOT be generated, and SHOULD be
            ; ignored.
      At-domain = "@" domain
	Mailbox = Local-part "@" Domain

and Domain is the usual definition.

So MailAddressParser Does The Right Thing already! Whee! Herewith attached
then a changeset with my previously-mentioned implementation, plus a
suitably amended test case.

frank
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SMTPClientBracketTest-fbs.2.cs
Type: application/octet-stream
Size: 3187 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20040323/6e380aaf/SMTPClientBracketTest-fbs.2.obj


More information about the Squeak-dev mailing list