[BUG] sourcesName incorrect(?)

Chris Reuter cgreuter at csclub.uwaterloo.ca
Sun May 9 18:56:50 UTC 2004


I noticed this while trying Boris Gaertner's shrink script for
Squeak-3.4: the method #sourcesName in SystemDictionary prepends the
path to the vm to the sources name:

	sourcesName
		"Answer the full path to the version-stable source code"
		^ self vmPath , SourceFileVersionString , FileDirectory dot , 'sources'

Thus, evaluating:

	Smalltalk sourcesName

yields:

	 '/usr/local/lib/squeak/3.6-3/SqueakV3.sources'

which is clearly incorrect.  In my installation (Linux), the Sources
file is in the local directory (or at least, a symbolic link to it is
there) and the directory that #sourcesName claims contains the sources
file isn't writable, which broke #condenseSources.

I fixed it in my case by changing sourcesName to:

	sourcesName
		"Answer the full path to the version-stable source code"
		^ SourceFileVersionString , FileDirectory dot , 'sources'

but I don't think that's correct in general.  

For what it's worth, my thinking, from the way the result is being
used, is that sourcesName should return only the filename and not the
complete path while the full filename should be pulled from somewhere
else.


                              --Chris	



-- 
Chris Reuter                                                 http://www.blit.ca
"This guy is nuts. Clearly, you should hit him in the head until the stupid
 falls out."
            --Elizabeth D. Brooks, <3FCCC23E.896EB47A at comcast.net>



More information about the Squeak-dev mailing list