Confused about SystemChangeNotification

Andreas Raab andreas.raab at gmx.de
Fri Apr 29 00:18:38 UTC 2005


Hi David,

>  0000845: ChangeSet losing class category changes in Squeak 3.7+

I checked this but it's only relevant in such that it exposes even more 
obscure behavior of SystemChangeNotification. For example, the 
notification that a class was recategorized happens to be done by 
ClassBuilder instead of SystemOrganizer. This is contrary to the pattern 
which we observe with classifying methods where the notification is 
handled by ClassOrganizer instead of Compiler or any other place. Having 
third parties notify these changes seems a fragile solution at best.

Cheers,
   - Andreas

PS. Okay, I'm sorry but I can't resist. Some of this code makes me sick 
- who came up with the great idea of requiring a pattern like:

	anEvent itemKind = SystemChangeNotifier classKind

instead of a simple "anEvent isClassChange"? And, not unexpectedly, zero 
comments and zero tests. Instead 13 classes where -by my careful 
counting- three are probably more than enough (in Tweak I'd do it 
without any new classes at all). This is so grossly over-"engineered" 
it's hardly believable. Where is the cleanup crew when you need it?



More information about the Squeak-dev mailing list