[ENH] Associations Please review and read the tests
Brent Pinkney
brent.pinkney at aircom.co.za
Mon Feb 14 05:17:07 UTC 2005
Hi,
I had a look at this code since installing the Chronology classes required
similar gymnastics not to break the image.
1. It would be nice to know soem background which motivated these changes.
2. The selector AssociationTests>>testtReadOnlyAssocEquality is misspelt.
3. Some of the tests use abbreviated names, some don't.
For readability for Those Who May Follow Us, raname methods like
testReadOnlyAssoc to
testReadOnlyAssociation.
4. Could these three .cs files not be bundled into one changeset ?
5. Do we really need ReadOnlyVariableBinding ?
I tested this in 3.9alpha-6548. All ok.
More information about the Squeak-dev
mailing list
|