Socket>>sendStreamContents:checkBlock:
goran at krampe.se
goran at krampe.se
Tue Apr 17 06:51:27 UTC 2007
Hi!
"Dominic Letz" <dominic.letz at berlin.de> wrote:
> Hello Everyone,
>
> when adding progress information to the FTPClient I found that this
> message has a Bug. It should call the "checkBlock" every 5000 thousand
> bytes - but does call it only once at the end of the file transfer.
> To fix this i suggest replacing the two lines:
>
> [[stream atEnd and: [checkBlock value]]
> whileFalse: [
>
> with:
>
> [[stream atEnd not and: [checkBlock value]]
> whileTrue: [
>
> I'm not very familiar with changesets so this seemed me the best way of
> submitting this hint.
I can at least say that the bug looks real (from staring at the code)
and your fix looks sound (from staring at it). :)
regards, Göran
More information about the Squeak-dev
mailing list
|