On Apr 30, 2007, at 3:11 PM, Andrew Tween wrote:

>
>> In all of this I'm not sure if people noticed another important
>> change we made in Sophie.
>>
>> That was changing emphasis from a magic number to an object.
>
> Yes, I noticed that. And I remember you mentioning it to me in the  
> past.
> It is a good idea.
> I have stuck with the existing magic number scheme mainly because  
> the thought of
> identifying, and changing, all the existing places where these  
> magic numbers are
> used seemed quite daunting.


I recall (it was years ago now) we altered things so that if you  
asked for the magic emphasis number you
would get a number back for backwards compatibility which was  
calculated from the font's emphasis object,
otherwise all the Sophie code worked with another accessor that gave  
back the emphasis object to work with.

For a year or so we ran with an assert to ensure no over eager  
developer stuffed a magic emphasis number into the emphasis object slot.


--
======================================================================== 
===
John M. McIntosh <johnmci at smalltalkconsulting.com>
Corporate Smalltalk Consulting Ltd.  http://www.smalltalkconsulting.com
======================================================================== 
===