[FIX] 6472: TraitBehavior>>#allClassVarNames is undefined

Damien Cassou damien.cassou at gmail.com
Tue May 8 18:42:14 UTC 2007


2007/5/8, Edgar J. De Cleene <edgardec2001 at yahoo.com.ar>:
> El 5/8/07 9:07 AM, "Mathieu Suen" <mathk.sue at gmail.com> escribió:
>
> > "
> > TraitBehavior contains class compatibility messages. However
> > #allClassVarNames is not implemented. eCompletion crashes often
> > because of that when working with traits. Attached patch implements
> > this missing method.
> > "
> >
> > I've added the fix in the list of fixes that need to be harvested:
> > http://www.squeak.org/squeak/5934
> >
> > Mth
>
>
> Mathieu:
> You made a first step, but we need more for including the fix.
>
> You don't include any test, so how I could know how good is your fix ?
>
> I copy
> > (tested in OmniBrowser and the OB Universe Browser, on a 3.10 squeak-dev
> image)
> I wish some in 3.10 base , what is what I working on.
>
> Maybe Damien could say what the fix is good.
> If he said that, I include into updates.

Hi Edgar,

in fact, we worked together to make some fixes today. I think the fix
is completely transparent and would not cause any problem because:

- it only implements 1 method.
- this method immediately returns an empty collection.
- the method did not exist before, neither in a super class nor in a
subclass. So, it does not hide any existing method.
- Mathieu wrote a test for it.

-- 
Damien Cassou


More information about the Squeak-dev mailing list