[BUGFIX] SqueakMap is broken in 3.10

Rob Withers reefedjib at yahoo.com
Mon Nov 5 17:01:37 UTC 2007


This has nothing to do with the bug you posted.  Here is the original 

= aVersion

    ^ numbers = aVersion numbers

It tests equality and not identity.  If aVersion is not a VersionNumber, 
which is the situation happening when streaming in data (version = String), 
then aVersion will not understand #numbers.

Here is my fix:

= aVersion

    ^ (aVersion isKindOf: VersionNumber)
        and: [numbers = aVersion numbers]

Which protects against that kind of business.

I now look to see how fast and efficient the bug processing loop is and see 
this make it into the image.  I have a feeling that it is not so efficient.


----- Original Message ----- 
From: "Matthew Fulmer" <tapplek at gmail.com>
To: <squeak-dev at lists.squeakfoundation.org>
Sent: Monday, November 05, 2007 8:45 AM
Subject: Re: [BUGFIX] SqueakMap is broken in 3.10

> On Mon, Nov 05, 2007 at 08:34:41AM -0800, Rob Withers wrote:
>> This dang VersionNumber class has a bad equality operation..  Here's a 
>> fix.
> http://bugs.squeak.org/view.php?id=2788
> -- 
> Matthew Fulmer -- http://mtfulmer.wordpress.com/
> Help improve Squeak Documentation: http://wiki.squeak.org/squeak/808

More information about the Squeak-dev mailing list