[squeak-dev] Re: [Etoys] etoys performance problems
Yoshiki Ohshima
yoshiki at vpri.org
Fri Apr 11 20:27:58 UTC 2008
> > > 1) fileIn fix
> > > In order to load a project bundle with an non-zipped .pr file in it,
> > > you've got to change the type of stream to create in
> > > projectStreamFromArchive from RWBinaryOrTextStream to
> > > MultiByteBinaryOrTextStream, since that's the class the project
> > > loading methods are defined on.
> >
> > Hmm. What was the performance impact by this?
>
> None, but when an uncompressed .pr file sits in another archive, the
> code that makes a stream for the .pr file makes the wrong kind of
> stream for said .pr file. So it's a simple bugfix.
But, this does make the current project loading slower to me. Try
(in an updated image):
MessageTally spyOn: [ProjectLoading loadFromDir:
'/usr/share/etoys/ExampleEtoys' projectName: 'DemonCastle1'].
or such with and without the change and see the result.
But, yes, I agree that there seems to be some potential "hanging
fruit" here. Thank you for attacking this!
-- Yoshiki
More information about the Squeak-dev
mailing list
|