Hi!

Andreas Raab wrote:
> Göran Krampe wrote:
>> You could harvest my fixes for those things on mantis. :) I fixed both 
>> the auth stuff and some other things.
> 
> Thank you, thank you, thank you. The encodeString: issue was news to me. 

Yeah, appeared when using Exim IIRC.

> Two question about correctness though:
> 
> 1) Doesn't 2821 specify that a client SHOULD send EHLO first and only 
> when declined, try HELO? Your fix seems to assume that the client knows 
> that the server is going to understand EHLO.

May very well be correct - it was a looong time since I looked at that 
stuff.

> 2) Isn't the domain included in HELO/EHLO supposed to be the server's 
> domain? You're using NetNameResolver localHostName which (in my 
> understanding of the RFC) would only be correct when connecting to 
> localhost.

Ah. Well, you are most probably right :) since I don't recall this stuff.

> Cheers,
>   - Andreas
> 

Btw, we have had Gjallar systems sending quite a lot of email using 
SMTPClient (but doing it in a separate Squeak process waking up and 
popping a queue in Magma). My feeling is that it has been stable.

regards, Göran