[squeak-dev] Failing tests

Igor Stasenko siguctua at gmail.com
Mon Dec 14 13:30:16 UTC 2009


2009/12/14 Levente Uzonyi <leves at elte.hu>:
> On Mon, 14 Dec 2009, Nicolas Cellier wrote:
>
>> 2009/12/14 Levente Uzonyi <leves at elte.hu>:
>>>
>>> Mirror primitives do not exists in the current vm. Will the vm have
>>> mirror
>>> primitives? Should we keep the tests? Removing these would "fix" 6
>>> errors.
>>>
>> As a general policy, I would say don't remove failing tests.
>> Declare them as known failures
>>
>
> I agree, but if the squeakvm won't have mirror primitives, then these tests
> are totally useless.
>

i think for such cases there should be a way to test if VM provides
new primitives, and if so, then run tests, otherwise just pass them
silently
>
> Levente
>
>> Nicolas
>>
>>> Building a vm with the latest VMMaker lets 6 failing test pass
>>> (AllocationTest, BitBltTests). It also avoids crashing linux as reported
>>> before
>>>
>>> (http://lists.squeakfoundation.org/pipermail/squeak-dev/2009-December/142074.html).
>>> And it also yields slight performance improvement because of the
>>> primitiveNextPut fix. Why aren't vm releases available with these fixes?
>>>
>>> There are two "great challenges" which would let most other failing tests
>>> pass:
>>> - fixing traits (the issues are solved in pharo, but one has to extract
>>> and
>>> integrate them)
>>> - fixing the decompiler (there's an issue with temporary variable
>>> declarations in inlined blocks)
>>> Is anybody working on these?
>>>
>>> If all the above is done, we will only have "minor" issues, like:
>>> - TextMorphTest>>#testInitialize which tries to add itself to the
>>> "Scripting" flap which doesn't exists. (should we remove that part?)
>>> - LocaleTest>>#testIsFontAvailable which probably has invalid assumptions
>>> about the fonts.
>>> - MorphicToolBuilderTests>>#testGetButtonSideEffectFree
>>>
>>>
>>> Cheers,
>>> Levente
>>>
>>>
>>
>>
>
>



-- 
Best regards,
Igor Stasenko AKA sig.



More information about the Squeak-dev mailing list