[squeak-dev] The Trunk: Network-ul.43.mcz

Mon Dec 14 16:06:16 UTC 2009

On Mon, 14 Dec 2009, Igor Stasenko wrote:

> why not just do:
>
> portNum ifNotNil: [
>  self httpProxyPort: portNum asNumber.
> ] ifNil: [ ... ]
>
> and get rid of class checking altogether?
>

I didn't look at the code at all, just fixed the issue some way. #isString 
would be better than the class check, but your idea is even better. The 
"funny" thing is that the HTTPPort variable is never read (I guess this 
is the reason why this bug was not fixed before), so something is 
broken here.

Levente

>
>
>
> -- 
> Best regards,
> Igor Stasenko AKA sig.
>
>