[squeak-dev] Failing tests

Igor Stasenko siguctua at gmail.com
Mon Dec 14 21:14:29 UTC 2009


2009/12/14 Germán Arduino <garduino at gmail.com>:
> I mean the two registrations on the non-existent Scripting Flap:
>
>                                        cl registerQuad: #(TextMorph            exampleBackgroundLabel  'Background
> Label' 'A piece of text that will occur on every card of the
> background')
>                                                forFlapNamed: 'Scripting'.
>                                                cl registerQuad:
> #(TextMorph             exampleBackgroundField          'Background Field'      'A  data field
> which will have a different value on every card of the background')
>                                                forFlapNamed: 'Scripting'.
>
> If you changes these two for "Supplies" the test go green. I'm not an
> expert on Flaps neither but think that this change is minor and
> shouldn't generate problems.
>

The question is, what this test trying to test. Adding stuff into flap?
Then why not create an anonymous flap instance and play with it and
then safely delete (GC) it at the end of test?

> Cheers.
> Germán.
>
>
>
> 2009/12/14 Levente Uzonyi <leves at elte.hu>:
>> On Mon, 14 Dec 2009, Germán Arduino wrote:
>>
>>> 2009/12/14 Levente Uzonyi <leves at elte.hu>:
>>>>
>>>> If all the above is done, we will only have "minor" issues, like:
>>>> - TextMorphTest>>#testInitialize which tries to add itself to the
>>>> "Scripting" flap which doesn't exists. (should we remove that part?)
>>>
>>> Why not register on Supplies and the test will be green?
>>>
>>
>> It's already there, see the last registration in TextMorph class >>
>> #registerInFlapsRegistry.
>>
>> One could fix this issue at least two different ways:
>> - remove the registrations for the scripting flap
>> - do nothing if someone tries to register something to a non-existsent flap
>>
>> The question is: which one is correct/better? Or is there an even better
>> solution? (I don't use flaps at all and I don't know much about them, so I
>> can't decide.)
>>
>>
>> Levente
>>
>>>
>>> Cheers.
>>> Germán.
>>>
>>
>>
>>
>>
>
>



-- 
Best regards,
Igor Stasenko AKA sig.



More information about the Squeak-dev mailing list