[squeak-dev] Re: MC ancestry slowness

Bert Freudenberg bert at freudenbergs.de
Sat Dec 19 16:50:57 UTC 2009


On 19.12.2009, at 16:26, Andreas Raab wrote:
> 
> Bert Freudenberg wrote:
>> I'd rather prune the search. I think inserting this line
>> 	(aVersionInfo hasAncestor: target) ifFalse: [^false].
>> before "self pushLayer" in MCFilteredVersionSorter>>processVersionInfo: would do the trick. At least in your example it works fine.
> 
> If you have any confidence in the change, please do. My problem is that I don't understand what exactly is going on in the search and consequently I'm not sure how to prune the search properly. Great example why tests are no replacement for comments btw.
> 
> Cheers,
>  - Andreas

I'm pretty sure this is fine. Apparently I added the same check to addVersionInfo: in 2005 ;)

Committed.

- Bert -





More information about the Squeak-dev mailing list