[squeak-dev] Help with PackageInfo-Base in inbox

Colin Putney cputney at wiresong.ca
Wed Dec 23 17:21:16 UTC 2009


On 2009-12-23, at 8:05 AM, Andreas Raab wrote:

> Folks -
> 
> I need some help with the PackageInfo-Base submission in the inbox. I'm simply uncertain if it is the correct implementation; it seems there is a potential issue there as the test makes an override to the package the method is defined in. This just smells funny and changing the way overrides get dealt with sounds a recipe for disaster if it goes wrong.
> 
> Anyone up for checking the submission and giving it a thumbs up or down?

Thumbs down, I say. It appears to reverse the meaning of overridden; ie, it causes #overriddenMethodsDo: to answer the methods it overrides in other packages, rather than the methods it contains which have been overridden by other packages.

Colin


More information about the Squeak-dev mailing list