On 21.10.2009, at 20:11, Nicolas Cellier wrote:

> Hi Eliot,
> This is experimental, not guaranteed bugfree.
> Indeed, you cannot #add: to nor #remove: from an Array... and elements
> won't be unique.
> My trunk image did not freeze because I analyzed senders of  
> #selectors in it.
> But sure, this might break foreign code...
> So yes, it deserves discussion.
>
> What do others think ?

I agree with Eliot. Keep the changes minimal - so just replace "keys"  
with "keys asSet" where necessary.

- Bert -

> Fortunately, it is very easy to retract this change...
> ...just have to check if aClass selectors sort is not sent directly.
> I don't think it is essential and I won't fight to defend it.
>
>
> Note that I also changed classVarNames as a sorted Array.
> I think this is a more interesting feature, because mostly used this  
> way.
>
> Do others agree on this one ?
>
> Nicolas
>
>
> 2009/10/21 Eliot Miranda <eliot.miranda at gmail.com>:
>> Again I think you should push the asSet into selectors.
>>
>> On Tue, Oct 20, 2009 at 5:55 PM, <commits at source.squeak.org> wrote:
>>>
>>> Nicolas Cellier uploaded a new version of Traits to project The  
>>> Trunk:
>>> http://source.squeak.org/trunk/Traits-nice.239.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Traits-nice.239
>>> Author: nice
>>> Time: 21 October 2009, 2:55 am
>>> UUID: da00b4a5-33ee-4d7e-bdf5-41e2d7ff90ae
>>> Ancestors: Traits-nice.238
>>>
>>> correct a missing #asSet after #keys refactoring
>>>
>>> =============== Diff against Traits-nice.238 ===============
>>>
>>> Item was changed:
>>>  ----- Method: TraitBehavior>>allSelectors (in category 'accessing  
>>> method
>>> dictionary') -----
>>>  allSelectors
>>> +       ^ self selectors asSet!
>>> -       ^ self selectors!
>>>
>>>
>>
>>
>>
>>
>>
>