[squeak-dev] Re: Pending inbox items: #removeAll and #flatten vs.
#flattened
Andreas Raab
andreas.raab at gmx.de
Fri Sep 18 02:57:29 UTC 2009
Nicolas Cellier wrote:
> 2009/9/17 Andreas Raab <andreas.raab at gmx.de>:
>> Nicolas - since you took the lead on removeAll, can I ask you to review and
>> merge it as appropriate (it looks like there are some specialized
>> implementations of #removeAll that may or may not be useful; it would be
>> good if you could check that).
>
> OK, some extensions are good and I uploaded them.
Thanks!
> Some others are conflicting and I did not upload them.
> They are good too: the main difference is that klub preserves the
> array of (OrderedCollection/Set/WeakSet) by using atAllPut: nil, while
> I created a new one.
> My implementation is a little cheaper for small/medium collections,
> but klub's might perform better for huge ones (less pressure on
> garbage collector). What do you think ?
I think it probably doesn't matter for now. If there is a real
performance difference someone will point it out and discuss it in
detail. For now I'd go with the simplest solution.
> Not enough Collection subclasses are tested. Someone should write more
> test because ...
Heh, heh. Yes, indeed.
Cheers,
- Andreas
More information about the Squeak-dev
mailing list
|