[squeak-dev] Right-click on workspace stops functioning

Frank Shearar frank.shearar at angband.za.org
Wed Apr 28 20:40:59 UTC 2010


On 2010/04/28 22:19, Frank Shearar wrote:
> On 2010/04/28 22:03, Bert Freudenberg wrote:
>> On 28.04.2010, at 21:56, Frank Shearar wrote:
>>>
>>> On 2010/04/26 21:28, Frank Shearar wrote:
>>>> On 2010/04/26 20:54, Chris Muller wrote:
>>>>>> In focused workspace window, press alt-o.
>>>>>> I'm not sure what it does, but sometimes, i pressing wrong keys
>>>>>> (instead of alt-p, or alt-i) and got my workspace duplicated.
>>>>>
>>>>> Yes, this happens to me too. I never was quite sure what the purpose
>>>>> of Command+o is supposed to be.. Does anyone know?
>>>>
>>>> I don't, but I know why at least. I'm still trying to figure out how
>>>> best to fix it though.
>>>
>>> I have a fix for the issue. It doesn't duplicate the old behavior
>>> exactly, because it makes a new Workspace with the same content as
>>> the old window (like the original behaviour, only with a working
>>> menu)... but leaves the original Workspace's contents unchanged.
>>>
>>> If that's acceptable, I'm happy to push the changes to the Inbox for
>>> perusal.
>>>
>>> frank
>>
>> What would be the point of that? Spawning means to stash away your
>> current train of thought and return to the latest saved version.
>> Having two windows with the same contents doesn't seem to make sense
>> to me.
>
> That's great. Chris asked the point of spawning, and I didn't know either.
>
> So, based on what you say above, and looking at TextEditor>>spawn, is
> this how Workspaces are supposed to work?
>
> Enter "3 + 4". Save. Change the text to "3 + 4 i". Spawn the Workspace.
> The NEW Workspace now has "3 + 4 i" as its contents, while the current
> one has "3 + 4", the contents as at the time you last hit cmd-s?
>
> Ah, indeed, that's how it's supposed to work according to trunk. OK.
> Well, my code's almost right then :) I'll make it all the way correct,
> and submit it to the Inbox.

And it's done.

Kernel-fbs.448 allows us to not only create and display a Workspace but 
to also return the instance so we can manipulate it.

Tools-fbs.236 lets the Workspace's view update.

And ToolBuilder-Morphic-fbs.58 does the relatively heavy lifting: 
instead of creating an ad hoc view for the Workspace, we ask the 
Workspace to use its own methods to do so (namely Workspace>>buildWith:).

frank



More information about the Squeak-dev mailing list