[squeak-dev] The Inbox: Kernel-mtf.528.mcz
Igor Stasenko
siguctua at gmail.com
Thu Dec 16 13:08:57 UTC 2010
On 16 December 2010 14:07, Igor Stasenko <siguctua at gmail.com> wrote:
> On 16 December 2010 08:08, Bert Freudenberg <bert at freudenbergs.de> wrote:
>>
>> On 16.12.2010, at 02:19, commits at source.squeak.org wrote:
>>
>>> Matthew Fulmer uploaded a new version of Kernel to project The Inbox:
>>> http://source.squeak.org/inbox/Kernel-mtf.528.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Kernel-mtf.528
>>> Author: mtf
>>> Time: 15 December 2010, 9:18:17.283 pm
>>> UUID: f111a9ad-3262-4a7f-98e8-1179c970d1cf
>>> Ancestors: Kernel-mtf.526
>>>
>>> Make the mouse button mappings be consistent across platforms, in the presence of the inconsistent Win32 VM
>>>
>>> =============== Diff against Kernel-mtf.526 ===============
>>>
>>> Item was changed:
>>> ----- Method: InputSensor class>>installMouseDecodeTable (in category 'class initialization') -----
>>> installMouseDecodeTable
>>> "Create a decode table that swaps the lowest-order 2 bits if
>>> + Preferences swapMouseButtons is set.
>>> +
>>> + Also swap if the platform is windows, for consistency with the
>>> + other platform VMs"
>>> + ButtonDecodeTable :=
>>> + (Preferences swapMouseButtons
>>> + xor: Smalltalk platformName = 'Win32')
>>> - Preferences swapMouseButtons is set"
>>> - ButtonDecodeTable := Preferences swapMouseButtons
>>> ifTrue: [ByteArray withAll:
>>> ((0 to: 255) collect: [:ea |
>>> ((ea bitAnd: 1) << 1
>>> bitOr: (ea bitAnd: 2) >> 1)
>>> bitOr: (ea bitAnd: 16rFC) ])]
>>> ifFalse: [ByteArray
>>> withAll: (0 to: 255)]!
>>>
>>>
>>
>> I don't think that's a good idea. How would you know which button mapping the user chose in his Windows VM settings? This just makes everything more complicated rather than less.
>
> By default, a mouse buttons in windows interpreted differently than on
> other platforms.
> If used change default settings for his VM , this is his own problems.
oops, a typo here 'used change' -> 'user changes'
> But i think that its good change, that when you moving image between
> platforms, the physical buttons mapping
> doesn't changing depending on platform.
>
> And to summarize: we don't need two settings for swapping mouse
> buttons - one in image, another in VM.
> This is what makes everything more complicated.
>
> Button settings should be left only in image, and from VM side, we
> should make sure that all VMs for all platforms
> interpret same physical buttons similarly.
>
>>
>> - Bert -
>>
>
> --
> Best regards,
> Igor Stasenko AKA sig.
>
--
Best regards,
Igor Stasenko AKA sig.
More information about the Squeak-dev
mailing list
|