On 12/26/2010 8:44 AM, Levente Uzonyi wrote:
> On Sun, 26 Dec 2010, Andreas Raab wrote:
>>> I think that the "FloatMath plugin issue" is Mantis 0007583: Float does
>>> not use FloatMathPlugin for bit-consistent float math across platforms.
>>>
>>> http://bugs.squeak.org/view.php?id=7583
>>
>> I went ahead and pushed the changes. They do look reasonable to me but
>> please everyone give it a shot and run all the float tests to ensure
>> it works on your favorite platform as well. In short, if all the tests
>> in KernelTests-Numbers pass, we're good, if any fail, please report
>> back with details.
>
> I described a remaining failure here:
> http://lists.squeakfoundation.org/pipermail/squeak-dev/2010-December/156108.html
>
> 'Note: There are two failing tests, because earlier "Float infinity sin"
> returned NaN, but it raises an error with the new code.'

I fixed those in the latest version.

> Also there's something strange in FloatConsistencyTests. It implements the
> md5 algorithm (it even uses the Croquet plugin if available), which is
> great, but it shouldn't be in a TestCase IMHO. Note that there's another
> MD5 implementation in the Cryptography package using another plugin
> (MD5Plugin) if available.

I'm not sure if we're settled on adding Cryptography-Core; if we do, 
then yes, we should kick the custom implementation out. I just need some 
MD5 implementation for the tests and since it's only a few methods, it's 
not all that problematic.

Cheers,
   - Andreas