[squeak-dev] The Trunk: Kernel-dtl.414.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Feb 28 18:32:28 UTC 2010


David T. Lewis uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-dtl.414.mcz

==================== Summary ====================

Name: Kernel-dtl.414
Author: dtl
Time: 28 February 2010, 1:30:32.921 pm
UUID: bca26e8e-d0b7-4ee0-a8f9-c27994a165e6
Ancestors: Kernel-dtl.413

Eliminate the "special menu..." pick from StringHolder class>>shiftedYellowBottonMenuItems for Morphic Retain a hook for it in MVC.

Rationale: The special menu items selection is currently broken, but never did anything useful in Morphic AFICT. Best to just remove the option when not in MVC, but leave the MVC hook in hopes of fixing the original MVC implementation later (other MVC issues prevent this now).

This changes adds another #isMorphic send, which is undesirable. However, a number of menu construction methods already have this issue, so a general solution is needed for tailoring these menus to different project types.

=============== Diff against Kernel-dtl.413 ===============

Item was changed:
  ----- Method: StringHolder class>>shiftedYellowButtonMenuItems (in category 'yellow button menu') -----
  shiftedYellowButtonMenuItems
  	"Returns the standard yellow button menu items"
+ 	| entries |
+ 	entries := OrderedCollection withAll:
+ 		{
+ 			{'explain' translated.					#explain}.
+ 			{'pretty print' translated.				#prettyPrint}.
+ 			{'pretty print with color' translated.		#prettyPrintWithColor}.
+ 			{'file it in (G)' translated.					#fileItIn}.
+ 			{'spawn (o)' translated.					#spawn}.
+ 			#-.
+ 			{'browse it (b)' translated.				#browseIt}.
+ 			{'senders of it (n)' translated.			#sendersOfIt}.
+ 			{'implementors of it (m)' translated.		#implementorsOfIt}.
+ 			{'references to it (N)' translated.			#referencesToIt}.
+ 			#-.
+ 			{'selectors containing it (W)' translated.	#methodNamesContainingIt}.
+ 			{'method strings with it (E)' translated.	#methodStringsContainingit}.
+ 			{'method source with it' translated.		#methodSourceContainingIt}.
+ 			{'class names containing it' translated.	#classNamesContainingIt}.
+ 			{'class comments with it' translated.		#classCommentsContainingIt}.
+ 			{'change sets with it' translated.			#browseChangeSetsWithSelector}.
+ 			#-.
+ 			{'save contents to file...' translated.		#saveContentsInFile}.
+ 			{'send contents to printer' translated.		#sendContentsToPrinter}.
+ 			{'printer setup' translated.				#printerSetup}.
+ 			#-.
+ 		}.
+ 	Smalltalk isMorphic ifFalse: [ entries add: 
+ 			{'special menu...' translated.				#presentSpecialMenu}.].
+ 	entries add:
+ 			{'more...' translated.					#yellowButtonActivity}.
+ 	^ entries!
- 	^{
- 		{'explain' translated.						#explain}.
- 		{'pretty print' translated.					#prettyPrint}.
- 		{'pretty print with color' translated.		#prettyPrintWithColor}.
- 		{'file it in (G)' translated.					#fileItIn}.
- 		{'spawn (o)' translated.						#spawn}.
- 		#-.
- 		{'browse it (b)' translated.					#browseIt}.
- 		{'senders of it (n)' translated.				#sendersOfIt}.
- 		{'implementors of it (m)' translated.		#implementorsOfIt}.
- 		{'references to it (N)' translated.			#referencesToIt}.
- 		#-.
- 		{'selectors containing it (W)' translated.	#methodNamesContainingIt}.
- 		{'method strings with it (E)' translated.	#methodStringsContainingit}.
- 		{'method source with it' translated.		#methodSourceContainingIt}.
- 		{'class names containing it' translated.	#classNamesContainingIt}.
- 		{'class comments with it' translated.		#classCommentsContainingIt}.
- 		{'change sets with it' translated.			#browseChangeSetsWithSelector}.
- 		#-.
- 		{'save contents to file...' translated.		#saveContentsInFile}.
- 		{'send contents to printer' translated.	#sendContentsToPrinter}.
- 		{'printer setup' translated.					#printerSetup}.
- 		#-.
- 		{'special menu...' translated.				#presentSpecialMenu}.
- 		{'more...' translated.						#yellowButtonActivity}.
- 	}!




More information about the Squeak-dev mailing list