[squeak-dev] The Trunk: Morphic-ar.305.mcz
Levente Uzonyi
leves at elte.hu
Tue Jan 12 04:15:03 UTC 2010
On Tue, 12 Jan 2010, commits at source.squeak.org wrote:
> Andreas Raab uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-ar.305.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-ar.305
> Author: ar
> Time: 11 January 2010, 8:05:58.998 pm
> UUID: 84c8e065-50b4-f94d-b056-90263e496c28
> Ancestors: Morphic-ul.304
>
> - Promote isScriptEditorMorph to Object.
Looking at current uses of #isScriptEditorMorph, it seems to be better
to keep it at Morph and add #isMorph checks to the two places which seem
to send it to other objects. This method also seems to be EToys related,
so moving is to the EToys package might be a good idea.
Thoughts?
Levente
> - Fix typo in prepareToBeSaved.
>
> =============== Diff against Morphic-ul.304 ===============
>
> Item was changed:
> ----- Method: PasteUpMorph>>prepareToBeSaved (in category 'misc') -----
> prepareToBeSaved
> "Prepare for export via the ReferenceStream mechanism"
>
> | exportDict soundKeyList players |
> super prepareToBeSaved.
> turtlePen := nil.
> self isWorldMorph
> ifTrue:
> [self removeProperty: #scriptsToResume.
> soundKeyList := Set new.
> (players := self presenter allExtantPlayers)
> do: [:aPlayer | aPlayer slotInfo
> associationsDo: [:assoc | assoc value type == #Sound
> ifTrue: [soundKeyList
> add: (aPlayer instVarNamed: assoc key)]]].
> players
> do: [:p | p allScriptEditors
> do: [:e | (e allMorphs
> select: [:m | m isSoundTile])
> do: [:aTile | soundKeyList add: aTile literal]]].
> (self allMorphs
> select: [:m | m isSoundTile])
> - isTileMorph
> do: [:aTile | soundKeyList add: aTile literal].
> soundKeyList removeAllFoundIn: SampledSound universalSoundKeys.
> soundKeyList
> removeAllSuchThat: [:aKey | (SampledSound soundLibrary includesKey: aKey) not].
> soundKeyList isEmpty
> ifFalse: [exportDict := Dictionary new.
> soundKeyList
> do: [:aKey | exportDict
> add: (SampledSound soundLibrary associationAt: aKey)].
> self setProperty: #soundAdditions toValue: exportDict]]!
>
> Item was removed:
> - ----- Method: Morph>>isScriptEditorMorph (in category 'classification') -----
> - isScriptEditorMorph
> - ^false!
>
>
>
More information about the Squeak-dev
mailing list
|