[squeak-dev] Re: The Trunk: Morphic-ar.305.mcz
leves at elte.hu
Tue Jan 12 06:30:15 UTC 2010
On Mon, 11 Jan 2010, Andreas Raab wrote:
> Levente Uzonyi wrote:
>> On Tue, 12 Jan 2010, commits at source.squeak.org wrote:
>>> Andreas Raab uploaded a new version of Morphic to project The Trunk:
>>> ==================== Summary ====================
>>> Name: Morphic-ar.305
>>> Author: ar
>>> Time: 11 January 2010, 8:05:58.998 pm
>>> UUID: 84c8e065-50b4-f94d-b056-90263e496c28
>>> Ancestors: Morphic-ul.304
>>> - Promote isScriptEditorMorph to Object.
>> Looking at current uses of #isScriptEditorMorph, it seems to be better to
>> keep it at Morph and add #isMorph checks to the two places which seem to
>> send it to other objects. This method also seems to be EToys related, so
>> moving is to the EToys package might be a good idea.
> Neither. For one thing, this method already says isScriptEditorMORPH so it
> obviously implies isMorph == true. (this would be different if it were
> isScriptEditor because there might be non-morph script editors).
In this case all is*Morph methods should be moved to Object from Morph.
> And it clearly can't be moved to the Etoys package - the whole purpose of the
> method is to make it possibly to unload Etoys and get isScriptEditorMorph ==
> false for all other objects. This would blow up straight into your face if
> you'd move it to Etoys. Same goes for MorphExtension>>actorState,
> MorphExtension>>player etc. They all need to stay in the original packages
> since after unloading Etoys these messages will still be sent; they will just
> never return true / non-nil respectively.
Of course moving it to EToys would require refactoring of the code.
> - Andreas
More information about the Squeak-dev