[squeak-dev] Re: New trunk server

Igor Stasenko siguctua at gmail.com
Tue Jan 12 10:57:23 UTC 2010


2010/1/12 Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>:
> 2010/1/12 Igor Stasenko <siguctua at gmail.com>:
>> 2010/1/12 Levente Uzonyi <leves at elte.hu>:
>>> On Tue, 12 Jan 2010, Igor Stasenko wrote:
>>>
>>>> 2010/1/12 Levente Uzonyi <leves at elte.hu>:
>>>>>
>>>>> On Mon, 11 Jan 2010, Nicolas Cellier wrote:
>>>>>
>>>>>> Hi Levente,
>>>>>> what about completely ignoring line endings in diffs ?
>>>>>>
>>>>>
>>>>> I intentionally added this feature. Do you think it's wrong?
>>>>>
>>>>>
>>>> IMO empty lines (and white space in general), is not an informal part
>>>> of source code,
>>>> so diffing them makes not much sense.
>>>
>>> Imagine that you removed lf characters from the code or you accidentally
>>> added some linefeeds while pasting code from and external source. The diff
>>> shows no changes. Is that OK?
>>>
>>
>> If the new lines is informal part of source code, i.e. belong to the
>> string literal:
>>
>> foo := '1
>> 2
>> 3
>>
>> 4
>> '.
>>
>> Then we should care. Otherwise not.
>
> True, there is a "semantic" difference as long as cr lf cr-lf have
> different semantic. But do they ?
> Since invisible characters are not an explicit specification robust to
> future editions, my expectations would be low on such code!
> My interpretation would be this one: if developer did rely on specific
> line-endings then she should care to explicitely specify line-endings.
> If she uses invisible specifications, then it means she just want
> whatever line-endings.
>
> Thus, I would not event bother with line endings inside literals and
> would tend to say: please use appropriate message (like
> withSqueakLineEnding)
>

+1 . A well-grounded argumentation.

> Nicolas
>




-- 
Best regards,
Igor Stasenko AKA sig.



More information about the Squeak-dev mailing list