[squeak-dev] Re: Uploading mczs to the Trunk (Was: Re: Working
with Trunk and Package loading)
leves at elte.hu
Mon Mar 8 01:05:11 UTC 2010
On Sun, 7 Mar 2010, Andreas Raab wrote:
> On 3/7/2010 3:18 PM, Levente Uzonyi wrote:
>> I think there's an unnecessary assert in
>> PackageDependencyTest>>#testPackage:dependsOnlyOn: which causes failure
>> if the package doesn't depend on a package which is contained by pkgList.
>> For example Compiler doesn't depend on Tools (according to
>> DependecyBrowser), but PackageDependencyTest>>#testCompiler passes Tools
>> as a possible dependency.
>> Removing this line
>> self assert: (pkgDeps includesKey: pkg).
> This choice was originally deliberate, since I'd like us to keep track of 'em
> explicitly, so if we remove a dependency we should update the test and try
> hard not to reintroduce it. However, since this test is supposed to help us
> in our work, we might reconsider the choice, if people feel that's not
I like the idea. This gives us another reason to run the tests before
> - Andreas
>> from PackageDependencyTest>>#testPackage:dependsOnlyOn: seems to be
>> fixing all failures (except #testTools, because Tools also depends on
>> Monticello which it shouldn't).
More information about the Squeak-dev