[squeak-dev] The Trunk: Tools-nice.210.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Mar 12 22:03:18 UTC 2010

Nicolas Cellier uploaded a new version of Tools to project The Trunk:

==================== Summary ====================

Name: Tools-nice.210
Author: nice
Time: 12 March 2010, 11:02:42.773 pm
UUID: 4b085222-d688-42bd-9471-df5771a211db
Ancestors: Tools-cmm.209

Let the debugger retain context selection when requested for fullStack.

Note: I don't like (self changed: #flash) for these reasons:
- it traverses all dependents (inefficient MVC like process)
- the text flash (not always, I don't know why), not the list from which the menu was triggered.

Maybe it would be better to disable the menu and the button when (contextStack last sender isNil).

=============== Diff against Tools-cmm.209 ===============

Item was changed:
  ----- Method: Debugger>>fullStack (in category 'context stack menu') -----
  	"Change from displaying the minimal stack to a full one."
+ 	contextStack last sender isNil
- 	self contextStackList size > 20 "Already expanded"
+ 			["Already expanded"
+ 			self changed: #flash]
- 			[self changed: #flash]
+ 			[| oldContextStackIndex |
+ 			oldContextStackIndex := contextStackIndex.
+ 			self fullyExpandStack.
+ 			oldContextStackIndex = contextStackIndex
+ 				ifFalse:
+ 					[self toggleContextStackIndex: oldContextStackIndex]]!
- 			[self contextStackIndex = 0 ifFalse: [
- 				self toggleContextStackIndex: self contextStackIndex].
- 			self fullyExpandStack]!

Item was changed:
  ----- Method: Debugger>>fullyExpandStack (in category 'context stack (message list)') -----
+ 	"Expand the stack to include all of it, rather than the first four or five contexts.
+ 	Well, almost all of it, we better maintain sane limits too."
- 	"Expand the stack to include all of it, rather than the first four or five
- 	contexts."
  	self okToChange ifFalse: [^ self].
+ 	self newStack: (contextStackTop stackOfSize: contextStack size + 100000).
- 	self newStack: contextStackTop contextStack.
  	self changed: #contextStackList!

More information about the Squeak-dev mailing list