[squeak-dev] The Trunk: Kernel-laza.428.mcz
Bert Freudenberg
bert at freudenbergs.de
Mon Mar 22 11:17:54 UTC 2010
On 22.03.2010, at 11:57, Levente Uzonyi wrote:
>
> On Mon, 22 Mar 2010, commits at source.squeak.org wrote:
>
>> Alexander Lazarević uploaded a new version of Kernel to project The Trunk:
>> http://source.squeak.org/trunk/Kernel-laza.428.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Kernel-laza.428
>> Author: laza
>> Time: 22 March 2010, 11:47:56.242 am
>> UUID: 5b1e683b-2d8c-4f21-b877-30e2426f1491
>> Ancestors: Kernel-ul.427
>>
>> Order instance variables alphabetically
>>
>> =============== Diff against Kernel-ul.427 ===============
>>
>> Item was changed:
>> ----- Method: Object>>longPrintOn:limitedTo:indent: (in category 'printing') -----
>> longPrintOn: aStream limitedTo: sizeLimit indent: indent
>> "Append to the argument, aStream, the names and values of all of the receiver's instance variables. Limit is the length limit for each inst var."
>>
>> + self class allInstVarNames asSortedArray doWithIndex:
>> - self class allInstVarNames doWithIndex:
>> [:title :index |
>> indent timesRepeat: [aStream tab].
>> aStream nextPutAll: title;
>> nextPut: $:;
>> space;
>> tab;
>> nextPutAll:
>> ((self instVarAt: index) printStringLimitedTo: (sizeLimit -3 -title size max: 1));
>> cr]!
>
> This won't work, because only the names are changed the indices are the same, so #instVarAt: will give the wrong value. Also #asSortedArray should be deprecated IMHO.
>
>
> Levente
Also, instance variable order is significant so in a debug method I'd rather prefer to not see it changed - what's your reasoning here?
- Bert -
More information about the Squeak-dev
mailing list
|