[squeak-dev] Please Add To Trunk (was: refactoring browser in Squeak?)

Eliot Miranda eliot.miranda at gmail.com
Wed Oct 27 21:09:08 UTC 2010


On Wed, Oct 27, 2010 at 1:52 PM, Levente Uzonyi <leves at elte.hu> wrote:

> On Wed, 27 Oct 2010, Eliot Miranda wrote:
>
>  Hi Tobias,
>>
>> On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape <Das.Linux at gmx.de> wrote:
>>
>>  Am 2010-10-25 um 18:08 schrieb Tim Felgentreff:
>>>
>>>> Kernel-topa.508, Compiler-tfel.175
>>>>
>>>
>>>
>> regarding  Compiler-tfel.175 I don't dee the point of this change.  The
>> preference is already called Preferences>allowUnderscoreAssignment so if
>> the
>> idea is to move to a pragma-based preference more needs to be done, and I
>> would call the method Scanner class>>allowUnderscoreAssignment, not add
>> two
>> extra selectors #allowUnderscoreAsAssignment and
>> #prefAllowUnderscoreAssignments.  What do these add except confusion?
>>
>
> In Pharo the preference accessor is called #allowUnderscoreAsAssignment in
> Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo
> version, since OB is developed for Pharo. So there are three choices:
> - add Compiler-tfel.175 to the Trunk
> - rename the preference accessor in Squeak to #allowUnderscoreAsAssignment
> - add a Squeak compatibility package for OB which implements this method as
> in Compiler-tfel.175
>

Off the top of my head, only the latter makes sense.  There are no senders
of allowUnderscoreAsAssignment in the base Compiler package so one would be
tempted to delete it.  Why can't it be an extension in OB?


>
> Levente
>
>
>
>> best
>> Eliot
>>
>>
>>  Has anybody objections to these two packages moving to trunk?
>>> If not, please, can a trunk developer integrate them?
>>>
>>> Thanks and
>>> So Long,
>>>        -Tobias
>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20101027/2f6cd566/attachment.htm


More information about the Squeak-dev mailing list