[squeak-dev] refactoring browser in Squeak?
Levente Uzonyi
leves at elte.hu
Thu Oct 28 15:13:22 UTC 2010
On Thu, 28 Oct 2010, Tim Felgentreff wrote:
> Also: Hmmm. Works here... Any errors?
It's a DNU. The relevant part of the stack trace is here:
ORPackageBrowser(Object)>>doesNotUnderstand: #definitionPanel
Receiver: an ORPackageBrowser
Arguments and temporary variables:
aMessage: definitionPanel
exception: MessageNotUnderstood: ORPackageBrowser>>definitionPanel
resumeValue: nil
Receiver's instance variables:
panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc...
announcer: an OBAnnouncer
cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc...
hasChanges: nil
ORPackageBrowser(OREnvironmentBrowser)>>selectionChanged:
Receiver: an ORPackageBrowser
Arguments and temporary variables:
anAnnouncement: an OBSelectionChanged
interval: nil
Receiver's instance variables:
panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc...
announcer: an OBAnnouncer
cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc...
hasChanges: nil
It I change the implementation to:
OREnvironmentBrowser >> selectionChanged: anAnnouncement
| interval |
interval := self environment selectionIntervalFor: self class definitionPanel text.
interval isNil ifFalse: [ self definitionPanel selection: interval ]
then it works.
Levente
>
> On Oct 28, 2010, at 5:01 PM, Tim Felgentreff wrote:
>
>> Yes, but we cannot use Lukas' versions - they are dependent on polymorph.
>>
>> On Oct 28, 2010, at 4:18 PM, Levente Uzonyi wrote:
>>
>>> On Mon, 25 Oct 2010, Tim Felgentreff wrote:
>>>
>>>> Hello
>>>>
>>>> There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
>>>
>>> The changes are in the Trunk, but if I evaluate this script:
>>>
>>> Installer squeaksource
>>> project: 'MetacelloRepository';
>>> install: 'ConfigurationOfOmniBrowser'.
>>> (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
>>>
>>> and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
>>>
>>>
>>> Levente
>>>
>>>>
>>>> Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
>>>>
>>>> Regards
>>>> Tim
>>>>
>>>
>>
>>
>
>
>
More information about the Squeak-dev
mailing list
|