[squeak-dev] The Trunk: Monticello-cmm.450.mcz

Hannes Hirzel hannes.hirzel at gmail.com
Wed Apr 6 09:45:36 UTC 2011


Is it correct to say that these difficulties with Monticello are
caused by trying to have OMeta load correctly? If yes maybe the fix
can be done on the OMeta side?

--Hannes

On 4/6/11, Bert Freudenberg <bert at freudenbergs.de> wrote:
> Hi Chris,
>
> this commit breaks reading configurations. It only manifests after flushing
> the MC caches so I guess you did not notice. But I "smelled" it right away
> when I saw the diff.
>
> Rather than extending your hack, I committed a version that reverts this
> change.
>
> The method takes a filename, and it should not mess with it. It is Installer
> that needs to supply the correct extension. This here is just plain wrong.
>
> - Bert -
>
> On 06.04.2011, at 02:44, commits at source.squeak.org wrote:
>
>> Chris Muller uploaded a new version of Monticello to project The Trunk:
>> http://source.squeak.org/trunk/Monticello-cmm.450.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Monticello-cmm.450
>> Author: cmm
>> Time: 5 April 2011, 9:44:09.466 pm
>> UUID: 162e8b0d-509b-4868-b460-a380bcc54898
>> Ancestors: Monticello-bf.449
>>
>> - Quick-fix for Installer; to be able to specify packages either with or
>> without a version-number.
>>
>> =============== Diff against Monticello-bf.449 ===============
>>
>> Item was changed:
>>  ----- Method: MCFileBasedRepository>>versionReaderForFileNamed:do: (in
>> category 'private-files') -----
>> + versionReaderForFileNamed: aString do: aBlock
>> + 	| fileName |
>> + 	fileName := (#('mcz' 'mcd' )
>> + 					anySatisfy: [:eachExtension | aString endsWith: eachExtension])
>> + 				ifTrue: [aString]
>> + 				ifFalse: [aString , '.mcz'].
>> - versionReaderForFileNamed: aString do: aBlock
>>  	^ self
>> + 		readStreamForFileNamed: fileName
>> + 		do: [:s | (MCVersionReader readerClassForFileNamed: fileName)
>> + 				ifNotNil: [:class | aBlock
>> + 						value: (class on: s fileName: fileName)]]!
>> - 		readStreamForFileNamed: aString
>> - 		do: [:s |
>> - 			(MCVersionReader readerClassForFileNamed: aString) ifNotNil:
>> - 				[:class | aBlock value: (class on: s fileName: aString)]]
>> - !
>>
>>
>
>
>



More information about the Squeak-dev mailing list