[squeak-dev] The Inbox: Monticello-cmm.452.mcz

Bert Freudenberg bert at freudenbergs.de
Thu Apr 7 09:38:29 UTC 2011


On 06.04.2011, at 20:19, Chris Muller wrote:

> Ok, I believe with this and the Installer-Core-cmm.349.mcz also in the
> Inbox, we can totally restore the legacy Installer behavior.
> 
> I recommend, however, that we only go with Installer-Core-cmm.349.mcz,
> which fixes our current Installer problem but does not restore the
> pure prefix-matching capability.  I just think that kind of power
> leaves too much uncertainty about what willl be loaded.
> 
> For example, I used Levente's example for my unit-test:
> 
>> Installer squeaksource
>>      project: 'Xtreams';
>>      install: 'Xtreams-Support';
>>      install: 'Xtreams-Core-';
>> ...
> 
> At one time this may have worked for Squeak to load
> Xtreams-Support-MartinKobetic.7.  However, in the last month,
> Xtreams-Support.gemstone-dkh.11 was added, and now that is selected
> based on prefix and mcSortBlock.
> 
> So, I personally prefer something more locked-down, but nevertheless
> offer this code for debate for integration.
> 
> - Chris

So far I have not seen anyone advocate to restore prefix matching. Explicit is better.

- Bert -

> On Wed, Apr 6, 2011 at 1:11 PM,  <commits at source.squeak.org> wrote:
>> A new version of Monticello was added to project The Inbox:
>> http://source.squeak.org/inbox/Monticello-cmm.452.mcz
>> 
>> ==================== Summary ====================
>> 
>> Name: Monticello-cmm.452
>> Author: cmm
>> Time: 6 April 2011, 1:10:57.3 pm
>> UUID: 28ca5b5d-ecfb-470b-900c-768f73a30a77
>> Ancestors: Monticello-bf.451
>> 
>> - Let MCFileBasedRepository's deviate on #versionNamesForPackageNamed:, to not require a whole package-name, but only a package-name prefix.
>>        This is inconsistent with other repository types as well as the API nomenclature, but should restore ability for Installer scripts to employ complicated prefixing version-selection.
>> 
>> =============== Diff against Monticello-bf.451 ===============
>> 
>> Item was changed:
>>  ----- Method: MCFileBasedRepository>>versionNamesForPackageNamed: (in category 'versions') -----
>>  versionNamesForPackageNamed: packageName
>> +       ^ Array
>> +               streamContents: [:stream | self allFileNamesOrCache
>> +                               do: [:each | (each beginsWith: packageName)
>> +                                               ifTrue: [stream nextPut: each]]]!
>> -       ^ Array streamContents:
>> -               [ : stream | self allFileNamesOrCache do:
>> -                       [ : each | | mcVersionName |
>> -                       mcVersionName := each asMCVersionName.
>> -                       mcVersionName packageName = packageName ifTrue: [ stream nextPut: mcVersionName ] ] ]!
>> 
>> 
>> 
> 





More information about the Squeak-dev mailing list