[squeak-dev] Add primitiveMillisecondClockMask? (was: The Trunk: Kernel-ar.564.mcz)

Eliot Miranda eliot.miranda at gmail.com
Wed Apr 13 18:57:32 UTC 2011


On Wed, Apr 13, 2011 at 11:09 AM, David T. Lewis <lewis at mail.msen.com>wrote:

> On Thu, Apr 07, 2011 at 09:04:41AM +0000, commits at source.squeak.org wrote:
> >
> > Andreas Raab uploaded a new version of Kernel to project The Trunk:
> > http://source.squeak.org/trunk/Kernel-ar.564.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Kernel-ar.564
> > Author: ar
> > Time: 7 April 2011, 11:04:21.248 am
> > UUID: 32ecb9c9-177a-ce45-9c1c-a3714c801929
> > Ancestors: Kernel-nice.563
> >
> > Fix computation of Time>>milliseconds:since: which would compute
> incorrect deltas upon clock overflow.
> >
> > =============== Diff against Kernel-nice.563 ===============
> >
> > Item was added:
> > + ----- Method: Time class>>millisecondClockMask (in category 'general
> inquiries') -----
> > + millisecondClockMask
> > +     "The VM mask for the max. millisecond clock value.
> > +     This should be primitive but it ain't so it's copied inline from
> the Interpreter."
> > +      ^16r1FFFFFFF!
> >
>
> Agreed, the millisecondClockMask should be available from a primitive.
> Should I make it so?
>

Personally I would much rather see us move to the 64-bit millisecond clock I
implemented for Cog. This renders the whole clock roll-over issue moot.

2¢
Eliot


>
> Dave
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20110413/bba12cbf/attachment.htm


More information about the Squeak-dev mailing list