[squeak-dev] The Inbox: Morphic-spd.507.mcz

Chris Muller asqueaker at gmail.com
Wed Jan 5 00:55:07 UTC 2011


To make the new comment even more precise, how clarifying by the term
"autoFit" instead of "TextMorph grows".

Also, convention is to not end the last line with a period.

On Tue, Jan 4, 2011 at 4:54 PM,  <commits at source.squeak.org> wrote:
> A new version of Morphic was added to project The Inbox:
> http://source.squeak.org/inbox/Morphic-spd.507.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-spd.507
> Author: spd
> Time: 4 January 2011, 5:54:07.209 pm
> UUID: c5d862d6-b70d-4ef2-b9e5-8018b9949701
> Ancestors: Morphic-cmm.506
>
> Added comments for TextMorph's #autoFit: and #wrapFlag:, which I find horrendously confusing.  They are
> probably badly named, but at minimum deserve better comments.
>
> =============== Diff against Morphic-cmm.506 ===============
>
> Item was changed:
>  ----- Method: TextMorph>>autoFit: (in category 'accessing') -----
>  autoFit: trueOrFalse
> +       "Whether I automatically adjust my size to fit text as it changes"
> +
>        self isAutoFit = trueOrFalse ifTrue: [^ self].
> +       self autoFitOnOff.!
> -       self autoFitOnOff!
>
> Item was changed:
>  ----- Method: TextMorph>>wrapFlag: (in category 'accessing') -----
>  wrapFlag: aBoolean
> +       "Whether contained text will adjust its bounds as I change shape:
> +               |       wrapFlag        |               TextMorph grows                 |               TextMorph shrinks       |
> +               |               true            | wrapped lines fill new space  |       long lines wrap to fit          |
> +               |               false           |   wrapped lines stay same             |       long lines are cut off          |"
> -       "Change whether contents are wrapped to the container."
>
>        aBoolean == wrapFlag ifTrue: [^ self].
>        wrapFlag := aBoolean.
>        self composeToBounds!
>
>
>



More information about the Squeak-dev mailing list