Possible Background fix (was: Re: [squeak-dev] Cuis 3,
some beginner questions)
Casey Ransberger
casey.obrien.r at gmail.com
Sat Jan 22 18:30:46 UTC 2011
Cool:)
The reason I didn't put background on the default theme: I didn't know how big your display was. I think the default themes should supply a nice set of subtle gradients for the background, personally. This also keeps the image small.
That said, backgrounds add a lot of "friendly" and I could be completely wrong here; I'm grateful that Juan added background capabilities to the theme engine.
What do other people think?
On Jan 22, 2011, at 7:23 AM, Mirko Kapps <mirkok.lists at googlemail.com> wrote:
> Hi Juan.
>
> My original idea of moving all really appearance related things into a DefaultTheme proved to be a little to complex and difficult for me. So, I decided to not mess around with this and just try to fix the background thing. What I came up with is a test whether a Theme defines #background and only then set the background using a new Theme class method #setBackground: . It's more of a hack than a real fix, I think, and it breaks subclassing somewhat. A theme *has* to define #background if it wants to set one, even if just the one from the super class. I personally rather like the behaviour, but decide you if it's OK.
>
> The added #setBackground: method has also the nice advantage that it is now really easy to set a background manually. It's just:
>
> Theme setBackground: Color blue
> Theme setBackground: '/home/mirko/Bilder/jungle_maze.jpg'
>
> Hope it's of some use. :-)
>
> ChangeSet attached.
>
> Kindest Regards
> Mirko
>
> <Theme-Background.cs>
>
More information about the Squeak-dev
mailing list
|