[squeak-dev] Re: Testing Seaside in Squeak4.3alpha-11321
Chris Muller
asqueaker at gmail.com
Fri Jun 3 01:38:20 UTC 2011
Extending the System workspace is obsolete and will be removed soon.
You may load Seaside from SqueakMap.
On Thu, Jun 2, 2011 at 2:21 PM, Stephane <stephane.schitter at free.fr> wrote:
> Hi - I just tested loading Seaside 3 from the "Extending the system" instructions in the latest 4.3 alpha (#11453), and the result is the same, the buttons in the seaside control panel are ineffective. The patch of Andreas solves it, is there a reason not to include this to trunk?
>
> Stephane
>
>
> Le 19 avr. 2011 à 17:26, Andreas Raab a écrit :
>
>> On 4/19/2011 17:06, Tobias Pape wrote:
>>> Curously, the buttons and the righ-click commands do not work,
>>> I suspect some OB-problems there.
>>
>> Yes, definitely. It appears as if the culprit is in the combination of OBButtonBar>>buttonFor: aCommand which will substitute #yourself as action selector when the button is inactive. However, later, when the button should be updated we hit an optimization in OBButtonBar>>updateCommands which attempts to avoid the full recreation of the buttons and uses OBButtonBar>>updateButton:for: which does not update the action selector. Curiously, the latter method has my initials on it :-) so I'm taking a bit responsibility here. I think we should change OBButtonBar>>updateButton:for: to say:
>>
>> updateButton: aButton for: aCommand
>>
>> ^aButton
>> model: aCommand;
>> setBalloonText: aCommand longDescription;
>> action: (aCommand isActive
>> ifTrue: [ #execute ]
>> ifFalse: [ #yourself ]);
>> yourself
>>
>> I'm not sure where to push this fix.
>>
>> Cheers,
>> - Andreas
>
>
>
More information about the Squeak-dev
mailing list
|