[squeak-dev] The Inbox: Monticello-fbs.467.mcz
frank.shearar at gmail.com
Thu Jun 9 19:11:08 UTC 2011
On 9 June 2011 17:37, Bert Freudenberg <bert at freudenbergs.de> wrote:
> On 09.06.2011, at 11:39, commits at source.squeak.org wrote:
>> A new version of Monticello was added to project The Inbox:
>> ==================== Summary ====================
>> Name: Monticello-fbs.467
>> Author: fbs
>> Time: 9 June 2011, 12:39:41.446 pm
>> UUID: b33cab1b-85b8-47a9-84eb-079a9778aaee
>> Ancestors: Monticello-ul.466
>> Better error messages for off-line work:
>> * If you can't find a base "full version", say so
>> * If you Give Up on trying to resolve a name, report the actual failure rather than trying to access a socket anyway, and throwing a primitive failed error.
>> =============== Diff against Monticello-ul.466 ===============
>> Item was changed:
>> ----- Method: MCDiffyVersion>>baseSnapshot (in category 'as yet unclassified') -----
>> + | baseRepo |
>> + baseRepo := self workingCopy repositoryGroup versionWithInfo: base.
>> + baseRepo ifNil: [Error signal: 'Missing snapshot: ', self baseInfo name].
>> + ^ baseRepo snapshot!
>> - ^ (self workingCopy repositoryGroup versionWithInfo: base) snapshot!
> "baseRepo" is misleading, this temp should be named "baseVersion". Perhaps even make a method "baseVersion" and use it here?
Agreed. I went with the smaller change, and just renamed the temp.
More information about the Squeak-dev