[squeak-dev] The Trunk: Morphic-spd.469.mcz

Chris Muller asqueaker at gmail.com
Tue Jun 21 23:03:00 UTC 2011


It doesn't quite say that..  It describes what it "only" (currently) is.

Are we saying LineMorph should not be first-class?


On Tue, Jun 21, 2011 at 5:49 PM, Levente Uzonyi <leves at elte.hu> wrote:
> On Tue, 21 Jun 2011, commits at source.squeak.org wrote:
>
>> Chris Muller uploaded a new version of Morphic to project The Trunk:
>> http://source.squeak.org/trunk/Morphic-spd.469.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Morphic-spd.469
>> Author: spd
>> Time: 1 October 2010, 2:20:39.508 pm
>> UUID: a68c21fa-d7d3-46da-82ea-53077512621a
>> Ancestors: Morphic-laza.468
>>
>> LineMorph class>>from:to:color:width: changed to return a LineMorph
>
> This change should be reverted IMHO. According to the class comment of
> LineMorph, it shouldn't have instances in the image.
>
>
> Levente
>
>>
>> =============== Diff against Morphic-laza.468 ===============
>>
>> Item was changed:
>>  ----- Method: LineMorph class>>from:to:color:width: (in category
>> 'instance creation') -----
>>  from: startPoint to: endPoint color: lineColor width: lineWidth
>>
>> +       ^ self vertices: {startPoint. endPoint}
>> -       ^ PolygonMorph vertices: {startPoint. endPoint}
>>                        color: Color black borderWidth: lineWidth
>> borderColor: lineColor!
>>
>>
>>
>
>



More information about the Squeak-dev mailing list