[squeak-dev] The Trunk: Monticello-cmm.437.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Mar 15 19:20:00 UTC 2011


Chris Muller uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-cmm.437.mcz

==================== Summary ====================

Name: Monticello-cmm.437
Author: cmm
Time: 12 March 2011, 5:14:17.148 pm
UUID: ff583452-e344-479e-9a82-4a1385f89992
Ancestors: Monticello-cmm.436

- Changed allVersionsDo: to enumerate packages in alphabetical, and their individual versions in versionNumber, order.
- Very old versions of MCVersionInfos don't always have a 'time', guard against that.
- Added conventional and necessary type-check in MCVersionName>>#=.

=============== Diff against Monticello-cmm.436 ===============

Item was changed:
  ----- Method: MCAncestry>>ancestors (in category 'ancestry') -----
  ancestors
+ 	^ ancestors ifNil: [ Array empty ]!
- 	^ ancestors ifNil: [#()]!

Item was changed:
  ----- Method: MCAncestry>>hasAncestor: (in category 'ancestry') -----
  hasAncestor: aVersionInfo
+ 	"Answer whether the receiver has ancestor, aVersionInfo."
+ "Would it be more performant to use a Set for alreadySeen:?"
  	^ self
  		hasAncestor: aVersionInfo
  		alreadySeen: OrderedCollection new!

Item was changed:
  ----- Method: MCRepository>>allVersionsDo: (in category 'versions') -----
+ allVersionsDo: aBlock
+ 	self allPackageNames asArray sort
- allVersionsDo: aBlock 
- 	self allPackageNames
  		do:
+ 			[ : eachPackageName | | sortedVersions |
+ 			sortedVersions := (self versionNamesForPackageNamed: eachPackageName) sort:
+ 				[ : a : b | a versionNumber < b versionNumber ].
+ 			sortedVersions
- 			[ : eachPackageName | (self versionNamesForPackageNamed: eachPackageName)
  				do:
  					[ : eachVersionName | (self versionNamed: eachVersionName) ifNotNil:
  						[ : ver | aBlock value: ver ] ]
  				displayingProgress:
  					[ : eachVersionName | 'Importing ' , eachVersionName ] ]
  		displayingProgress:
  			[ : eachPackageName | 'Importing versions of ' , eachPackageName ]!

Item was added:
+ ----- Method: MCVersionInfo>>dateAndTime (in category 'accessing') -----
+ dateAndTime
+ 	^ DateAndTime
+ 		date: date
+ 		time: (time ifNil: [ Time midnight ])!

Item was changed:
  ----- Method: MCVersionName>>= (in category 'testing') -----
  = aByteString 
  	"Ignore any file-extension for comparison of MCVersionNames."
  	| myVersionName |
+ 	aByteString isString ifFalse: [ ^ false ].
  	myVersionName := self versionName.
  	^ (myVersionName
  		compare: myVersionName
  		with: aByteString asMCVersionName versionName
  		collated: AsciiOrder) = 2!




More information about the Squeak-dev mailing list