[squeak-dev] The Trunk: Monticello-bf.485.mcz
Levente Uzonyi
leves at elte.hu
Tue Nov 1 22:09:55 UTC 2011
On Tue, 1 Nov 2011, commits at source.squeak.org wrote:
> Bert Freudenberg uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-bf.485.mcz
This is a pretty good change. I think it would be worth extending MC's
package saving dialog with the two panels of the Patch Browser. This way
the changes could be checked during saving and we wouldn't have to bother
adding these new informations to the summary text that appears below the
commit message.
Levente
>
> ==================== Summary ====================
>
> Name: Monticello-bf.485
> Author: bf
> Time: 1 November 2011, 11:51:41.087 am
> UUID: a8baac8f-5e9b-42ad-b70b-125a6abada01
> Ancestors: Monticello-bf.484
>
> - be more descriptive than 'source same but rev changed'
>
> =============== Diff against Monticello-bf.484 ===============
>
> Item was added:
> + ----- Method: MCDefinition>>summarySuffixOver: (in category 'printing') -----
> + summarySuffixOver: previousDefinition
> + ^self source = previousDefinition source
> + ifTrue: [ ' (source same but rev changed)' ]
> + ifFalse: [ ' (changed)' ]!
>
> Item was added:
> + ----- Method: MCMethodDefinition>>summarySuffixOver: (in category 'printing') -----
> + summarySuffixOver: previousDefinition
> + | sourceChanged categoryChanged timeStampChanged |
> + sourceChanged := self source ~= previousDefinition source.
> + timeStampChanged := self timeStamp ~= previousDefinition timeStamp.
> + categoryChanged := self category ~= previousDefinition category.
> + sourceChanged | timeStampChanged | categoryChanged
> + ifFalse: [ ^super summarySuffixOver: previousDefinition ].
> + sourceChanged ifTrue: [
> + ^categoryChanged
> + ifTrue: [ ' (changed and recategorized)' ]
> + ifFalse: [ ' (changed)' ] ].
> + timeStampChanged & categoryChanged
> + ifTrue: [^ ' (recategorized and different time stamp)' ].
> + ^categoryChanged
> + ifTrue: [ ' (only recategorized)' ]
> + ifFalse: [ ' (only different time stamp)' ]
> + !
>
> Item was changed:
> ----- Method: MCModification>>summarySuffix (in category 'accessing') -----
> summarySuffix
> + ^ modification summarySuffixOver: obsoletion
> + !
> - ^self fromSource = self toSource
> - ifTrue: [ ' (source same but rev changed)' ]
> - ifFalse: [ ' (changed)' ]!
>
>
>
More information about the Squeak-dev
mailing list
|