[squeak-dev] The Trunk: Tools-bf.383.mcz
Bert Freudenberg
bert at freudenbergs.de
Wed Oct 12 09:50:03 UTC 2011
On 12.10.2011, at 11:35, Frank Shearar <frank.shearar at gmail.com> wrote:
> On 11 October 2011 15:11, <commits at source.squeak.org> wrote:
>> Bert Freudenberg uploaded a new version of Tools to project The Trunk:
>> http://source.squeak.org/trunk/Tools-bf.383.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tools-bf.383
>> Author: bf
>> Time: 11 October 2011, 4:11:42.987 pm
>> UUID: c27c59ef-77c3-46c3-b24a-b0034efcd457
>> Ancestors: Tools-eem.382
>>
>> VersionsBrowser: when reverting a method, put it in the previous category, too.
>>
>> =============== Diff against Tools-eem.382 ===============
>
> Nice! I ran into this the other day but wasn't online to report it,
> and then forgot to!
>
> It's a pity the original code uses "cat" and "category" as variable
> names. "oldCategory" might be a better name (for a separate commit)?
>
> frank
The method argument is the current category. Renaming it could make this a little more clear, but since it's used in only one place near the top I didn't feel it was worth it. Also, the method signature would become even longer than it is now.
- Bert -
More information about the Squeak-dev
mailing list
|