On Fri, 3 Aug 2012, Frank Shearar wrote:

> On 3 August 2012 21:27,  <commits at source.squeak.org> wrote:
>> Frank Shearar uploaded a new version of Collections to project The Trunk:
>> http://source.squeak.org/trunk/Collections-fbs.482.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Collections-fbs.482
>> Author: fbs
>> Time: 3 August 2012, 9:26:33.402 pm
>> UUID: f236f58a-ba49-4c8c-8314-731f82206158
>> Ancestors: Collections-ael.481
>>
>> Merge Collections-ael.481
>>
>> remove spurious sharing of associations between a dictionary and another created from it
>>
>> =============== Diff against Collections-cwp.480 ===============
>>
>> Item was changed:
>>   ----- Method: Dictionary class>>newFrom: (in category 'instance creation') -----
>>   newFrom: aDict
>>         "Answer an instance of me containing the same associations as aDict.
>>          Error if any key appears twice."
>>         | newDictionary |
>>         newDictionary := self new: aDict size.
>>         aDict associationsDo:
>>                 [:x |
>>                 (newDictionary includesKey: x key)
>>                         ifTrue: [self error: 'Duplicate key: ', x key printString]
>> +                       ifFalse: [newDictionary add: x copy]].
>> -                       ifFalse: [newDictionary add: x]].
>>         ^ newDictionary
>>
>>   "     NewDictionary newFrom: {1->#a. 2->#b. 3->#c}
>>         {1->#a. 2->#b. 3->#c} as: NewDictionary
>>         NewDictionary newFrom: {1->#a. 2->#b. 1->#c}
>>         {1->#a. 2->#b. 1->#c} as: NewDictionary
>>   "!
>>
>> Item was added:
>> + ----- Method: WeakRegistry class>>migrateOldRegistries (in category 'migrating registry') -----
>> + migrateOldRegistries
>
> Grr. Ael's commit didn't change this method, and I merged it in, so I
> don't know why it got added. Seperate commit re-removes it.

It keeps sneaking back every once in a while. We should find the reason 
why it's happening.


Levente

>
> frank
>
>