[squeak-dev] The Trunk: NetworkTests-ul.32.mcz

Levente Uzonyi leves at elte.hu
Tue Aug 14 23:08:33 UTC 2012


On Tue, 14 Aug 2012, Frank Shearar wrote:

> On 14 August 2012 14:54, David T. Lewis <lewis at mail.msen.com> wrote:
>> When running on Cog, the original network support code is used. If the
>> new network support primitives are present, then the updated code is
>> used, which includes use of SocketAddress to represent socket addresses
>> rather than four byte ByteArray. There are some places where exceptions
>> are raised in the new support code associated with the use of SocketAddress.
>>
>> I can't say if this is right or not, but raising an exception when
>> asking for the peerName of an uninitialized socket does not seem too
>> unreasonable.
>
> The test fails on my machine because in Socket >> #remoteSocketAddress
> the size local variable is assigned -1. SocketAddress new: -1 then
> fails. The -1 comes from the return value of self
> primSocketRemoteAddressSize: socketHandle. (So clearly NetNameResolver
> useOldNetwork returns false.)

It seems to be an incompatibility between old and new code, but it's okay. 
I'll update the test soon.


Levente

>
> frank
>
>> Dave
>>
>> On Tue, Aug 14, 2012 at 02:41:05PM +0200, Levente Uzonyi wrote:
>>> On Tue, 14 Aug 2012, David T. Lewis wrote:
>>>
>>>> This may be an issue in Socket class>>remoteSocketAddress that is
>>>> exposed when running with the new network support. The test attempts
>>>> to do "Socket new peerName" which does not work (but should it???).
>>>
>>> It works for me on windows and linux using Cog, thought the behavior is
>>> inconsistent. I get a string on windows and nil on linux.
>>> Btw #remoteSocketAddress is not used (and should not be used) when
>>> #peerName is sent if #useOldNetwork is true.
>>>
>>>
>>> Levente
>>>
>>>>
>>>> Dave
>>>>
>>>>
>>>>
>>
>
>


More information about the Squeak-dev mailing list