Hi Edgar,

    the package comment is good.  But the source isn't.  If I were to come
back in a year or two I would want to know why the send line had been
commented out and why the appendVocabularies: method had been kept.  But
reading the source I would have no clue.


On Tue, Dec 18, 2012 at 3:22 AM, <commits at source.squeak.org> wrote:

> A new version of GetText was added to project The Inbox:
> http://source.squeak.org/inbox/GetText-edc.26.mcz
>
> ==================== Summary ====================
>
> Name: GetText-edc.26
> Author: edc
> Time: 18 December 2012, 8:23:27.014 am
> UUID: a6073c36-9cee-4419-a727-389696afd8ad
> Ancestors: GetText-nice.25
>
> This modification is for when you perform Smalltalk unloadAllKnownPackages
> on Squeak4.4-RC2.tgz the image don't crash
>
> =============== Diff against GetText-nice.25 ===============
>
> Item was changed:
>   ----- Method: GetTextExporter>>appendTranslations: (in category
> 'exporting') -----
>   appendTranslations: domains
>         self appendStringReceivers: #translated into: domains.
>         self appendStringReceivers: #translatedNoop into: domains.
> +       "self appendVocabularies: domains."
> -       self appendVocabularies: domains.
>   !
>
> Item was removed:
> - ----- Method: GetTextExporter>>appendVocabularies: (in category
> 'private') -----
> - appendVocabularies: domains
> -       | literalsForDomain references domainName methodReference |
> -
> -       EToyVocabulary allPhrasesWithContextToTranslate do: [ :r |
> -               methodReference :=  (MethodReference new setStandardClass:
> (r second) methodSymbol: (r third)).
> -               "domainName := self getTextDomainForPackage:
> (PackageOrganizer default packageOfMethod: methodReference)".
> -               domainName := 'Etoys-Tiles'.
> -               literalsForDomain := domains at: domainName ifAbsentPut:
> [Dictionary new].
> -               r fourth do: [ :literal |
> -                       references := literalsForDomain at: literal
> ifAbsentPut: [OrderedCollection new].
> -                       references add: methodReference.
> -               ].
> -       ].
> -       !
>
>
>


-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20121218/f0e0b282/attachment.htm