[squeak-dev] The Inbox: Tools-ael.394.mcz

Frank Shearar frank.shearar at gmail.com
Thu Jul 26 06:51:32 UTC 2012


On 26 July 2012 00:01, Aran Lunzer <aranlunzer at gmail.com> wrote:
> Hi -
>
> Frank Shearar wrote:
>>> In a FileList there are some operations (such as 'install into new
>>> change set' and 'fileIn entire file', both on a .st file) that can be
>>> invoked from the file list, but on the contents pane lead to a
>>> walkback.
>>>
>>> The problem arises from the setup of the contents-pane menu in
>>> FileList>>fileContentsMenu:shifted:, where menu items are connected to
>>> ServiceEntry instances that have an invalid 'served' object.
>>>
>>> The relevant bit of the old code is
>>>
>>>                 aMenu
>>>                         addServices: services
>>>                         for: self fullName
>>>                         extraLines: extraLines
>>>
>>> which looks like it should be
>>>
>>>                 aMenu
>>>                         addServices: services
>>>                         for: self
>>>                         extraLines: extraLines
>>>
>>> ...because the served object (the fileList) will be asked its fullName
>>> when the service is invoked.
>>
>> I just tried, in an updated trunk image, to "install into new change
>> set", and everything worked just fine. Is this fix still necessary?
>
> For us the problem seems to be there just as before.  Note that the
> error arises when invoking the operation from the code pane, not the
> file-list pane.

Ah, the _lower_ of the two panes. I will check the fix again later today.

Thanks for the update, and if Tools fixes aren't landing quick enough,
feel free to nag me!

frank

> All the best -
>
> Aran
>


More information about the Squeak-dev mailing list