[squeak-dev] The Trunk: Tools-fbs.413.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Jun 11 19:46:18 UTC 2012


Frank Shearar uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.413.mcz

==================== Summary ====================

Name: Tools-fbs.413
Author: fbs
Time: 11 June 2012, 8:45:35.501 pm
UUID: 04131505-191d-4f46-ba9e-64195d2ed007
Ancestors: Tools-eem.412

#showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods).

=============== Diff against Tools-eem.412 ===============

Item was changed:
  ----- Method: CodeHolder>>selectedMessage (in category 'message list') -----
  selectedMessage
  	"Answer a copy of the source code for the selected message.  This generic version is probably actually never reached, since every subclass probably reimplements and does not send to super.  In time, ideally, most, or all, reimplementors would vanish and all would defer instead to a universal version right here.  Everything in good time."
  
  	| class selector method |
  	contents ifNotNil: [^ contents copy].
  
  	self showingDecompile ifTrue:[^ self decompiledSourceIntoContents].
  
  	class := self selectedClassOrMetaClass.
  	(class isNil or: [(selector := self selectedMessageName) isNil]) ifTrue: [^ ''].
  	method := class compiledMethodAt: selector ifAbsent: [^ ''].	"method deleted while in another project"
  	currentCompiledMethod := method.
  
+ 	^ contents := (self showingDocumentation
- 	^ contents := (self showComment
  		ifFalse: [self sourceStringPrettifiedAndDiffed]
  		ifTrue:	[ self commentContents])
  			copy asText makeSelectorBoldIn: class!

Item was removed:
- ----- Method: CodeHolder>>showComment (in category 'what to show') -----
- showComment
- 	"Answer whether the receiver should show documentation rather than, say, source code"
- 
- 	^ self contentsSymbol == #documentation
- !



More information about the Squeak-dev mailing list