Eliot, I just realized that Command+Shift+C is already allocated to
"show category (C)" -- which is useful and still works because the
keyboard handler method was not actually updated (that I saw
anyway..).

Should we think of with a different hot-key (maybe Command+Shift+R ?)
to handle it?


On Mon, Apr 16, 2012 at 3:52 PM,  <commits at source.squeak.org> wrote:
> Eliot Miranda uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-eem.402.mcz
>
> ==================== Summary ====================
>
> Name: Tools-eem.402
> Author: eem
> Time: 16 April 2012, 1:52:23.177 pm
> UUID: 60d5c35a-b436-4fb2-af42-9af40bfb4001
> Ancestors: Tools-eem.401
>
> Provide a short-cut (cmd-shift-C) for copyReference.
>
> Nuke null method in TimeProfileBrowser's menu processing.
>
> Make the same bounds check in the indirect temp ref side
> of privateDereference:in:.
>
> =============== Diff against Tools-eem.401 ===============
>
> Item was changed:
>  ----- Method: Browser>>messageListMenu:shifted: (in category 'message functions') -----
>  messageListMenu: aMenu shifted: shifted
>        "Answer the message-list menu"
>        self
>                menuHook: aMenu
>                named: #messageListMenu
>                shifted: shifted.
>        Preferences useOnlyServicesInMenu ifTrue:[^aMenu].
>        shifted ifTrue: [^ self shiftedMessageListMenu: aMenu].
>        aMenu addList: #(
>                        ('what to show...'                      offerWhatToShowMenu)
>                        ('toggle break on entry'                toggleBreakOnEntry)
>                        -
>                        ('browse full (b)'                      browseMethodFull)
>                        ('browse hierarchy (h)'                 classHierarchy)
>                        ('browse method (O)'                    openSingleMessageBrowser)
>                        ('browse protocol (p)'                  browseFullProtocol)
>                        -
> +                       ('fileOut'                                      fileOutMessage)
> +                       ('printOut'                                     printOutMessage)
> +                       ('copy selector (c)'                    copySelector)
> +                       ('copy reference (C)'           copyReference)
> -                       ('fileOut'                              fileOutMessage)
> -                       ('printOut'                             printOutMessage)
> -                       ('copy selector (c)'                                            copySelector)
> -                       ('copy reference'                                               copyReference)
>                        -
>                        ('senders of... (n)'                    browseSendersOfMessages)
>                        ('implementors of... (m)'               browseMessages)
>                        ('inheritance (i)'                      methodHierarchy)
>                        ('versions (v)'                         browseVersions)
>                        -
>                        ('references... (r)'                    browseVariableReferences)
>                        ('assignments... (a)'                   browseVariableAssignments)
>                        ('class refs (N)'                       browseClassRefs)
>                        -
>                        ('remove method (x)'                    removeMessage)
>                        ('explore method'                       exploreMethod)
>                        ('inspect method'                       inspectMethod)
>                        -
>                        ('more...'                              shiftedYellowButtonActivity)).
>        ^ aMenu!
>
> Item was changed:
>  ----- Method: DebuggerMethodMapForClosureCompiledMethods>>privateDereference:in: (in category 'private') -----
>  privateDereference: tempReference in: aContext
>        "Fetch the temporary with reference tempReference in aContext.
>         tempReference can be
>                integer - direct temp reference
>                #( indirectionVectorIndex tempIndex ) - remote temp in indirectionVector at index
>                #( outer. temp reference ) - a temp reference in an outer context."
>        ^tempReference isInteger
>                ifTrue:
>                        [tempReference <= aContext stackPtr ifTrue:
>                                [aContext tempAt: tempReference]]
>                ifFalse:
>                        [tempReference first == #outer
>                                ifTrue:
>                                        [self privateDereference: tempReference last
>                                                in: aContext outerContext]
>                                ifFalse: "If stopped before indirection vectors are created they will be nil. Simply answer nil"
> +                                       [tempReference first <= aContext stackPtr ifTrue:
> +                                               [(aContext tempAt: tempReference first) ifNotNil:
> +                                                       [:indirectionVector|
> +                                                       indirectionVector at: tempReference second]]]]!
> -                                       [(aContext tempAt: tempReference first) ifNotNil:
> -                                               [:indirectionVector|
> -                                               indirectionVector at: tempReference second]]]!
>
> Item was changed:
>  ----- Method: MessageSet>>messageListMenu:shifted: (in category 'message functions') -----
>  messageListMenu: aMenu shifted: shifted
>        "Answer the message-list menu"
>        self
>                menuHook: aMenu
>                named: #messageListMenu
>                shifted: shifted.
>        Preferences useOnlyServicesInMenu ifTrue:[^aMenu].
>        shifted ifTrue: [^ self shiftedMessageListMenu: aMenu].
>        aMenu addList: #(
>                        ('what to show...'                      offerWhatToShowMenu)
>                        ('toggle break on entry'                toggleBreakOnEntry)
>                        -
>                        ('browse full (b)'                      browseMethodFull)
>                        ('browse hierarchy (h)'                 classHierarchy)
>                        ('browse method (O)'                    openSingleMessageBrowser)
>                        ('browse protocol (p)'                  browseFullProtocol)
>                        -
>                        ('fileOut'                              fileOutMessage)
>                        ('printOut'                             printOutMessage)
> +                       ('copy selector (c)'            copySelector)
> +                       ('copy reference (C)'   copyReference)
> -                       ('copy selector (c)'                                            copySelector)
> -                       ('copy reference'                                               copyReference)
>                        -
>                        ('senders of... (n)'                    browseSendersOfMessages)
>                        ('implementors of... (m)'               browseMessages)
>                        ('inheritance (i)'                      methodHierarchy)
>                        ('versions (v)'                         browseVersions)
>                        -
>                        ('references... (r)'                    browseVariableReferences)
>                        ('assignments... (a)'                   browseVariableAssignments)
>                        ('class refs (N)'                       browseClassRefs)
>                        -
>                        ('remove method (x)'                    removeMessage)
>                        ('explore method'                       exploreMethod)
>                        ('inspect method'                       inspectMethod)
>                        -
>                        ('more...'                              shiftedYellowButtonActivity)).
>        ^ aMenu!
>
> Item was changed:
>  ----- Method: RecentMessageSet>>messageListMenu:shifted: (in category 'message functions') -----
>  messageListMenu: aMenu shifted: shifted
>        "Answer the message-list menu"
>
>        shifted ifTrue: [^ self shiftedMessageListMenu: aMenu].
>        aMenu addList:#(
>                        ('what to show...'                                              offerWhatToShowMenu)
>                        -
>                        ('browse full (b)'                                              browseMethodFull)
>                        ('browse hierarchy (h)'                                 classHierarchy)
>                        ('browse method (O)'                                    openSingleMessageBrowser)
>                        ('browse protocol (p)'                                  browseFullProtocol)
>                        -
> +                       ('fileOut (o)'                                                          fileOutMessage)
> -                       ('fileOut (o)'                                                  fileOutMessage)
>                        ('printOut'                                                             printOutMessage)
>                        ('copy selector (c)'                                            copySelector)
> +                       ('copy reference (C)'                                   copyReference)
> -                       ('copy reference'                                               copyReference)
>                        -
>                        ('senders of... (n)'                                            browseSendersOfMessages)
>                        ('implementors of... (m)'                                       browseMessages)
> +                       ('inheritance (i)'                                                      methodHierarchy)
> -                       ('inheritance (i)'                                              methodHierarchy)
>                        ('versions (v)'                                                 browseVersions)
>                        -
>                        ('references... (r)'                                            browseVariableReferences)
>                        ('assignments... (a)'                                           browseVariableAssignments)
>                        ('class refs (N)'                                                       browseClassRefs)
>                        -
>                        ('remove method (x)'                                    removeMessage)
>                        ('remove from RecentSubmissions'                removeFromRecentSubmissions)
>                        -
>                        ('more...'                                                              shiftedYellowButtonActivity)).
>        ^ aMenu!
>
> Item was removed:
> - ----- Method: TimeProfileBrowser>>messageListMenu:shifted: (in category 'private') -----
> - messageListMenu: aMenu shifted: shifted
> -       "Add a menu to the inherited one."
> -
> -       | menu |
> -       menu := super messageListMenu: aMenu shifted: shifted.
> - "     menu addItem: (0)."
> -       ^menu!
>
>