[squeak-dev] The Trunk: Compiler-eem.239.mcz
David T. Lewis
lewis at mail.msen.com
Tue Nov 6 21:30:50 UTC 2012
On Tue, Nov 06, 2012 at 01:11:08PM -0800, Eliot Miranda wrote:
> On Tue, Nov 6, 2012 at 12:54 PM, Eliot Miranda <eliot.miranda at gmail.com>wrote:
> > On Tue, Nov 6, 2012 at 5:44 AM, David T. Lewis <lewis at mail.msen.com>wrote:
> >> This update results in a new test failure in
> >> ClosureCompilerTest>>testDecompiledDoitMethodTempNames.
> >> This is probably just a test issue that can be fixed with an update to
> >> ClosureCompilerTest>>closureCases, but I am not an expert here.
> >> Eliot, Nicolas - could one of you please check this and fix the test if
> >> that is what is required?
> > done. checking in soon.
> >> Also, a new test to document the problem being fixed by this update would
> >> be a good thing.
> > will do.
> Hmmm. Turns out to be rather hard to write the test. Both the new code
> and the old code are trying to print whileTrue:  as whileTrue, and the
> compiler is trying to compile whileTrue:  as whileTrue. So all forces
> move against leaving whileTrue:  alone, and the bug was that the old code
> would transform whileTrue:  into whileTrue when printing. So forgive me
> for now but I'll fix the decompiler and not write the test for the original
> fix :-/.
Thanks a lot for following up on this, #testDecompiledDoitMethodTempNames
is passing now.
More information about the Squeak-dev